Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of detection logic Mobile-Detect@2.8.13 ? #28

Closed
knubew opened this issue May 10, 2015 · 4 comments
Closed

Integration of detection logic Mobile-Detect@2.8.13 ? #28

knubew opened this issue May 10, 2015 · 4 comments

Comments

@knubew
Copy link

knubew commented May 10, 2015

Thank you for updating the integration of detection logic to Mobile-Detect@2.8.13

I just have a short question. Do you use the current Version "Detect Mobile Browsers" (http://detectmobilebrowsers.com/) for integration which was released at 1 August 2014?

@hgoebl
Copy link
Owner

hgoebl commented May 11, 2015

The patterns were not up-to-date. I've updated them. Difference: the new patterns recognize 'windows phone' as a mobile device.
I'm waiting for a possible bug in Mobile-Detect patterns regarding Windows Phone OS detection before building the next version.

@knubew
Copy link
Author

knubew commented May 12, 2015

Thanks for updating the "Detect Mobile Browsers" patterns.

Is there any reason why you did not add "|android|ipad|playbook|silk" to the first regex?

Under http://detectmobilebrowsers.com/about the author states:

Tablets
Android tablets, iPads, Kindle Fires and PlayBooks are not detected by design. To add support for tablets, add |android|ipad|playbook|silk to the first regex.tablets.

@hgoebl
Copy link
Owner

hgoebl commented May 14, 2015

Yet another valuable input, thanks!
I'm thinking about either

a) add this pattern to the first regex, or
b) add another pattern to distinguish between "generic-phone/mobile" and "generic-tablet". Of course it's would only improve detection heuristic a bit, but maybe better than nothing.

What do you think is better?

@knubew
Copy link
Author

knubew commented May 14, 2015

phuuu, good question. I use version a) for nearly two years now and it works good and it's proven. But maybe version b) might be the better way for upcoming devices in the future !? - At least it's up to you, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants