Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect phone from sumsung galaxy j7 or Android OS return null #87

Closed
masato48 opened this issue Sep 10, 2018 · 3 comments
Closed

detect phone from sumsung galaxy j7 or Android OS return null #87

masato48 opened this issue Sep 10, 2018 · 3 comments

Comments

@masato48
Copy link

masato48 commented Sep 10, 2018 •
edited
Loading

detect phone from sumsung galaxy j7 or Android OS return null

user-agent from sumsung galaxy j7 prime is
Mozilla/5.0 (Linux; Android 7.0; SM-G610F Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.91 Mobile Safari/537.36

but phone detect is null

const md = new MobileDetect(req.headers['user-agent'])
console.log(md.mobile())
console.log(md.phone())
console.log(md.tablet())

result

UnknownMobile
null
null

I change to other Android Device
result the same
@stevenalanstark
Copy link

also happening on iOS 13

@hgoebl
Copy link
Owner

hgoebl commented Sep 13, 2019

Do you remember the text showing up when creating an issue?

I repeat:

Important Note

Before creating an issue, please note:

mobile-detect is just a kind of "satellite"-project. It uses the RegEx patterns of
Mobile-Detect and generates JavaScript source code
based on the code of its "mother"-project.

Missing patterns for particular devices cannot be added in mobile-detect.js,
instead you have to create an issue in Mobile-Detect.

Please provide the User-Agent string, the manufacturer and the type of device (phone, tablet, tv, bot, ...).

I won't replicate your issue to Mobile-Detect!

It doesn't make any sense to change generated code. I hope you understand.

Issue

[ ] I've read above note and I'm quite sure I have a real issue with mobile-detect.js

... you can delete above note and just describe your issue ...

@hgoebl hgoebl closed this as completed Sep 13, 2019
@hgoebl
Copy link
Owner

hgoebl commented Sep 14, 2019

SM-G610F should be added as a pattern in the Mobile-Detect project, not here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hgoebl @stevenalanstark @masato48