Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Mobile Registers as Phone on http://demo.mobiledetect.net/ but not in JS library #78

Closed
gregelenbaas opened this issue Jan 25, 2018 · 1 comment

Comments

@gregelenbaas
Copy link

Important Note

Before creating an issue, please note:

mobile-detect is just a kind of "satellite"-project. It uses the RegEx patterns of
Mobile-Detect and generates JavaScript source code
based on the code of its "mother"-project.

Missing patterns for particular devices cannot be added in mobile-detect.js,
instead you have to create an issue in Mobile-Detect.

Please provide the User-Agent string, the manufacturer and the type of device (phone, tablet, tv, bot, ...).

I won't replicate your issue to Mobile-Detect!

It doesn't make any sense to change generated code. I hope you understand.

Issue

[x ] I've read above note and I'm quite sure I have a real issue with mobile-detect.js

Hi there,

Firefox mobile doesn't have a phone object returned from the md.phone() method.

The mobile-detect project works correctly when testing at http://demo.mobiledetect.net/ for user-agent:
Mozilla/5.0 (Android 4.4; Mobile; rv:46.0) Gecko/46.0 Firefox/46.0

This leads me to believe this is an issue with mobile-detect.js.

Thank you for your stewardship of this project!

@gregelenbaas
Copy link
Author

So this is not actually an issue, my bad. The md.mobile() works for Firefox on Android just not the md.phone() which makes sense. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant