Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the library broken? #73

Closed
AvraamMavridis opened this issue Jan 2, 2018 · 4 comments
Closed

Is the library broken? #73

AvraamMavridis opened this issue Jan 2, 2018 · 4 comments

Comments

@AvraamMavridis
Copy link

AvraamMavridis commented Jan 2, 2018

Issue

Seems that many of the libraries functions returns null, even on the demo page:

screen shot 2018-01-02 at 13 53 18

e.g. md.userAgent()

Is a bug on the library or is a change on Chrome/Firefox that broke it?

@hgoebl
Copy link
Owner

hgoebl commented Jan 2, 2018

I really hope that it's not broken. And I also think that it's OK. Maybe the demo (not included in this project) is out-dated. Try this:

http://hgoebl.github.io/mobile-detect.js/check/

Please keep in mind that the library's target is "mobile", so when using desktop browsers, most features won't work as one might expect.

@AvraamMavridis
Copy link
Author

Please keep in mind that the library's target is "mobile", so when using desktop browsers, most features won't work as one might expect.

I see, probably that's the issue, I dont see the user agent on desktop. Thx.

@virtualbjorn
Copy link

virtualbjorn commented Jul 24, 2019

Is it possible to extend its feature to desktop as well?

This is a really great plugin and such feature will improve its usability more.

@hgoebl
Copy link
Owner

hgoebl commented Jul 24, 2019

Probably not. There is not much contribution to this project and the "mother"-project written in PHP. It's kind of starving, I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants