Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about moving constants to a separate file? #72

Closed
teobais opened this issue Dec 23, 2017 · 1 comment
Closed

What about moving constants to a separate file? #72

teobais opened this issue Dec 23, 2017 · 1 comment

Comments

@teobais
Copy link

teobais commented Dec 23, 2017

Hello,

nice effort.

However, I think it would be much cleaner if we kept constants like phone, tablets, etc. in an isolated file, like the way it's done for math.js or international-anniversary.

How does this sound to you?

Cheers,
Thodoris

@hgoebl
Copy link
Owner

hgoebl commented Dec 24, 2017

Generally a good idea. But in this case, the js file is generated based on a template without the constants. So from a maintenance point of view, I think it's already ok if you look at the "real" source files.
And those guys who want to load the code into the browser are glad to have only a single request.

@hgoebl hgoebl closed this as completed Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants