doc / package info after issue #10

hgoebl · Jul 16, 2014 · 338c15d · 338c15d
1 parent da397b4
commit 338c15d
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 24 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,8 @@
+v0.4.1:
+  date: <not-released-yet>
+  changes:
+    - fix issue #10 (optimization: no need to eval code before it's not required)
+
 v0.4.0:
   date: 2014-07-15
   changes:

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
     "name": "mobile-detect",
-    "version": "0.4.0",
+    "version": "0.4.1-SNAPSHOT",
     "description": "Device detection (phone, tablet, desktop, mobile grade, os, versions)",
     "homepage": "http://hgoebl.github.io/mobile-detect.js/",
     "keywords": [

diff --git a/mobile-detect.js b/mobile-detect.js
@@ -1,7 +1,8 @@
 // THIS FILE IS GENERATED - DO NOT EDIT!
 /*global module:false, define:false*/
 
-(function (exports, undefined) {
+(function (define, undefined) {
+define(function () {
     'use strict';
 
     var mobileDetectRules = {
@@ -797,12 +798,9 @@
         }
     };
 
-    exports(MobileDetect);
-
-})(function (data, undefined) {
-
+    // environment-dependent
     if (typeof window !== 'undefined' && window.screen && window.screen.width) {
-        data.isPhoneSized = function (maxPhoneWidth) {
+        MobileDetect.isPhoneSized = function (maxPhoneWidth) {
             if (maxPhoneWidth < 0) {
                 return undefined;
             }
@@ -813,22 +811,20 @@
             return cssPixelWidth <= maxPhoneWidth;
         };
     } else {
-        data.isPhoneSized = function () {};
+        MobileDetect.isPhoneSized = function () {};
     }
 
-    if (typeof module !== 'undefined' && module.exports) {
-
-        module.exports = data;
-
-    } else if (typeof define === 'function' && define.amd) {
-
-        define(function () { return data; });
-
+    return MobileDetect;
+}); // end of call of define()
+})((function (undefined) {
+    if (typeof define === 'function' && define.amd) {
+        return define;
+    } else if (typeof module !== 'undefined' && module.exports) {
+        return function (factory) { module.exports = factory(); };
     } else if (typeof window !== 'undefined') {
-
-        window.MobileDetect = data;
-
+        return function (factory) { window.MobileDetect = factory(); };
     } else {
-        throw new Error('unknown environment'); // please file a bug if you get this error!
+        // please file a bug if you get this error!
+        throw new Error('unknown environment');
     }
-});
+})());
diff --git a/mobile-detect.min.js b/mobile-detect.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "mobile-detect",
-    "version": "0.4.0",
+    "version": "0.4.1-SNAPSHOT",
     "description": "Device detection (phone, tablet, desktop, mobile grade, os, versions)",
     "main": "mobile-detect.js",
     "scripts": {