implemented device type determination using smallest-width qualifier #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgoebl
added a commit
that referenced
this pull request
Mar 22, 2015
implemented device type determination using smallest-width qualifier
hgoebl
added a commit
that referenced
this pull request
Mar 22, 2015
- use Mobile-Detect@2.8.12
- breaking change: phone() and tablet() won't return 'UnknownMobile' -> have to check mobile() as well (issue #20)
- breaking change: fallback detection phone/tablet is now based on smaller screen side (issue #23)
- expose internal implementation in case somebody wants to quick fix or monkey-patch the behaviour
- add demo page for gh-pages
- tweak jshint
hgoebl
added a commit
that referenced
this pull request
Mar 22, 2015
- use Mobile-Detect@2.8.12
- breaking change: phone() and tablet() won't return 'UnknownMobile' -> have to check mobile() as well (issue #20)
- breaking change: fallback detection phone/tablet is now based on smaller screen side (issue #23)
- expose internal implementation in case somebody wants to quick fix or monkey-patch the behaviour
- add demo page for gh-pages
- tweak jshint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented android approach to handle multiple screen sizes.
Fixed density independent width calculation.
Resolves #22