We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I found an issue regarding to determining device based on screen width. We divide screen width on device pixel ratio.
var physicalPixelWidth = window.screen.width, pixelRatio = window.devicePixelRatio || 1, cssPixelWidth = physicalPixelWidth / pixelRatio;
It's mistakenly because window.screen.width already has density independent pixels value (tested on several real devices).
So I suggest to eliminate this division.
Actually it'll be good to use smallest-width qualifier approach instead - the same as android use to determine small/large screen devices.
The text was updated successfully, but these errors were encountered:
implemented device type determination using smallest-width qualifier. R…
8dd00df
…esolves hgoebl#22
Successfully merging a pull request may close this issue.
I found an issue regarding to determining device based on screen width.
We divide screen width on device pixel ratio.
It's mistakenly because window.screen.width already has density independent pixels value (tested on several real devices).
So I suggest to eliminate this division.
Actually it'll be good to use smallest-width qualifier approach instead - the same as android use to determine small/large screen devices.
The text was updated successfully, but these errors were encountered: