Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdsBot-Google UA #18

Closed
wants to merge 3 commits into from
Closed

Add AdsBot-Google UA #18

wants to merge 3 commits into from

Conversation

finik
Copy link

@finik finik commented Jan 6, 2015

@hgoebl
Copy link
Owner

hgoebl commented Jan 6, 2015

I'm sorry, but mobile-detect.js is not the source for the User-Agent regular expressions. They are maintained in the project Mobile-Detect. This project is only a "satellite". Thanks for your efforts and willing to contribute :-)

@hgoebl hgoebl closed this Jan 6, 2015
@finik
Copy link
Author

finik commented Jan 6, 2015

Should I submit it there? With current implementation many of google bots are not recognized properly. New facebook bot UA is not recognized as well.

@hgoebl
Copy link
Owner

hgoebl commented Jan 6, 2015

Submitting it there sounds like a good idea. But please follow projects' contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants