Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device list #103

Closed
jimmydjabali opened this issue May 18, 2020 · 1 comment
Closed

Update device list #103

jimmydjabali opened this issue May 18, 2020 · 1 comment

Comments

@jimmydjabali
Copy link

The device list of mobile-detect.js were updated last time in September 2019, and now new phones came out (eg. Galaxy S20).

Did you planned to update the device model list ?

@hgoebl
Copy link
Owner

hgoebl commented May 18, 2020

Important Note

Before creating an issue, please note:

mobile-detect is just a kind of "satellite"-project. It uses the RegEx patterns of
Mobile-Detect and generates JavaScript source code
based on the code of its "mother"-project.

Missing patterns for particular devices cannot be added in mobile-detect.js,
instead you have to create an issue in Mobile-Detect.

Please provide the User-Agent string, the manufacturer and the type of device (phone, tablet, tv, bot, ...).

I won't replicate your issue to Mobile-Detect!

It doesn't make any sense to change generated code. I hope you understand.

Issue

[ ] I've read above note and I'm quite sure I have a real issue with mobile-detect.js

... you can delete above note and just describe your issue ...

@hgoebl hgoebl closed this as completed May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants